1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
|
// file : mod/mod-ci-github.cxx -*- C++ -*-
// license : MIT; see accompanying LICENSE file
#include <mod/mod-ci-github.hxx>
#include <libbutl/json/parser.hxx>
#include <mod/module-options.hxx>
#include <iostream>
// @@ TODO
//
// Building CI checks with a GitHub App
// https://docs.github.com/en/apps/creating-github-apps/writing-code-for-a-github-app/building-ci-checks-with-a-github-app
//
// @@ TODO Best practices
//
// Webhooks:
// https://docs.github.com/en/webhooks/using-webhooks/best-practices-for-using-webhooks
//
// REST API:
// https://docs.github.com/en/rest/using-the-rest-api/best-practices-for-using-the-rest-api?apiVersion=2022-11-28
//
// Creating an App:
// https://docs.github.com/en/apps/creating-github-apps/about-creating-github-apps/best-practices-for-creating-a-github-app
//
// Use a webhook secret to ensure request is coming from Github. HMAC:
// https://en.wikipedia.org/wiki/HMAC#Definition. A suitable implementation
// is provided by OpenSSL.
// @@ Authenticating to use the API
//
// There are three types of authentication:
//
// 1) Authenticating as an app. Used to access parts of the API concerning
// the app itself such as getting the list of installations. (Need to
// authenticate as an app as part of authenticating as an app
// installation.)
//
// 2) Authenticating as an app installation (on a user or organisation
// account). Used to access resources belonging to the user/repository
// or organisation the app is installed in.
//
// 3) Authenticating as a user. Used to perform actions as the user.
//
// We need to authenticate as an app installation (2).
//
// How to authenticate as an app installation
//
// Reference:
// https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation
//
// The final authentication token we need is an installation access token
// (IAT), valid for one hour, which we will pass in the `Authentication`
// header of our Github API requests:
//
// Authorization: Bearer <INSTALLATION_ACCESS_TOKEN>
//
// To generate an IAT:
//
// - Generate a JSON Web Token (JWT)
//
// The inputs are (one of) the application's private key(s) and the
// application ID, which goes into the "issuer" JWT field. Also the
// token's issued time and expiration time (10 minutes max).
//
// The best library for us seems to be libjwt at
// https://github.com/benmcollins/libjwt which is also widely packaged
// (most Linux distros and Homebrew).
//
// Doing it ourselves:
//
// Github requires the RS256 algorithm, which is RSA signing using
// SHA256.
//
// The message consists of a base64url-encoded JSON header and
// payload. (base64url differs from base64 by having different 62nd and
// 63rd alphabet characters (- and _ instead of ~ and . to make it
// filesystem-safe) and no padding because the padding character '=' is
// unsafe in URIs.)
//
// Header:
//
// {
// "alg": "RS256",
// "typ": "JWT"
// }
//
// Payload:
//
// {
// "iat": 1234567,
// "exp": 1234577,
// "iss": "<APP_ID>"
// }
//
// Where:
// iat := Issued At (NumericDate)
// exp := Expires At (NumericDate)
// iss := Issuer
//
// Signature:
//
// RSA_SHA256(PKEY, base64url($header) + "." + base64url($payload))
//
// JWT:
//
// base64url($header) + "." +
// base64url($payload) + "." +
// base64url($signature)
//
// - Get the installation ID. This will be included in the webhook request
// in our case
//
// - Send a POST to /app/installations/<INSTALLATION_ID>/access_tokens
// which includes the JWT (`Authorization: Bearer <JWT>`). The response
// will include the IAT. Can pass the name of the repository included in
// the webhook request to restrict access, otherwise we get access to all
// repos covered by the installation if installed on an organisation for
// example.
using namespace std;
using namespace butl;
using namespace web;
using namespace brep::cli;
brep::ci_github::ci_github (const ci_github& r)
: handler (r),
options_ (r.initialized_ ? r.options_ : nullptr)
{
}
void brep::ci_github::
init (scanner& s)
{
options_ = make_shared<options::ci> (
s, unknown_mode::fail, unknown_mode::fail);
}
// The "check_suite" object within a check_quite webhook request.
//
struct check_suite
{
uint64_t id;
string head_branch;
string head_sha;
string before;
string after;
explicit
check_suite (json::parser&);
check_suite () = default;
};
struct repository
{
string name;
string full_name;
string default_branch;
explicit repository (json::parser&);
repository () = default;
};
struct check_suite_event
{
string action;
::check_suite check_suite;
::repository repository;
explicit check_suite_event (json::parser&);
check_suite_event () = default;
};
static ostream&
operator<< (ostream&, const check_suite&);
static ostream&
operator<< (ostream&, const repository&);
static ostream&
operator<< (ostream&, const check_suite_event&);
bool brep::ci_github::
handle (request& rq, response& rs)
{
using namespace bpkg;
HANDLER_DIAG;
// @@ TODO
if (false)
throw invalid_request (404, "CI request submission disabled");
// Process headers.
//
string event;
{
bool content_type (false);
for (const name_value& h: rq.headers ())
{
if (icasecmp (h.name, "x-github-delivery") == 0)
{
// @@ TODO Check that delivery UUID has not been received before
// (replay attack).
}
else if (icasecmp (h.name, "content-type") == 0)
{
if (!h.value)
throw invalid_request (400, "missing content-type value");
if (icasecmp (*h.value, "application/json") != 0)
{
throw invalid_request (400,
"invalid content-type value: '" + *h.value +
'\'');
}
content_type = true;
}
else if (icasecmp (h.name, "x-github-event") == 0)
{
if (!h.value)
throw invalid_request (400, "missing x-github-event value");
event = *h.value;
}
}
if (!content_type)
throw invalid_request (400, "missing content-type header");
if (event.empty ())
throw invalid_request (400, "missing x-github-event header");
}
// There is an event (specified in the x-github-event header) and each event
// contains a bunch of actions (specified in the JSON request body).
//
// Note: "GitHub continues to add new event types and new actions to
// existing event types." As a result we ignore known actions that we are
// not interested in and log and ignore unknown actions. The thinking here
// is that we want be "notified" of new actions at which point we can decide
// whether to ignore them or to handle.
//
try
{
if (event == "check_suite")
{
json::parser p (rq.content (64 * 1024), "check_suite webhook");
check_suite_event cs (p);
// @@ TODO: log and ignore unknown.
//
if (cs.action == "requested")
{
}
else if (cs.action == "rerequested")
{
// Someone manually requested to re-run the check runs in this check
// suite.
}
else if (cs.action == "completed")
{
// GitHub thinks that "all the check runs in this check suite have
// completed and a conclusion is available". Looks like this one we
// ignore?
}
else
throw invalid_request (400, "unsupported action: " + cs.action);
cout << "<check_suite webhook>" << endl << cs << endl;
return true;
}
else if (event == "pull_request")
{
throw invalid_request (501, "pull request events not implemented yet");
}
else
throw invalid_request (400, "unexpected event: '" + event + "'");
}
catch (const json::invalid_json_input& e)
{
// @@ TODO: should we write more detailed diagnostics to log? Maybe we
// should do this for all unsuccessful calls to respond().
//
// @@ TMP These exceptions end up in the apache error log.
//
throw invalid_request (400, "malformed JSON in request body");
}
}
using event = json::event;
// check_suite
//
check_suite::check_suite (json::parser& p)
{
p.next_expect (event::begin_object);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
const string& n (p.name ());
if (n == "id") id = p.next_expect_number<uint64_t> ();
else if (n == "head_branch") head_branch = p.next_expect_string ();
else if (n == "head_sha") head_sha = p.next_expect_string ();
else if (n == "before") before = p.next_expect_string ();
else if (n == "after") after = p.next_expect_string ();
else p.next_expect_value_skip ();
}
}
static ostream&
operator<< (ostream& os, const check_suite& cs)
{
os << "id: " << cs.id << endl
<< "head_branch: " << cs.head_branch << endl
<< "head_sha: " << cs.head_sha << endl
<< "before: " << cs.before << endl
<< "after: " << cs.after << endl;
return os;
}
// repository
//
repository::repository (json::parser& p)
{
p.next_expect (event::begin_object);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
const string& n (p.name ());
if (n == "name") name = p.next_expect_string ();
else if (n == "full_name") full_name = p.next_expect_string ();
else if (n == "default_branch") default_branch = p.next_expect_string ();
else p.next_expect_value_skip ();
}
}
static ostream&
operator<< (ostream& os, const repository& rep)
{
os << "name: " << rep.name << endl
<< "full_name: " << rep.full_name << endl
<< "default_branch: " << rep.default_branch << endl;
return os;
}
// check_suite_event
//
check_suite_event::check_suite_event (json::parser& p)
{
p.next_expect (event::begin_object);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
const string& n (p.name ());
if (n == "action") action = p.next_expect_string ();
else if (n == "check_suite") check_suite = ::check_suite (p);
else if (n == "repository") repository = ::repository (p);
else p.next_expect_value_skip ();
}
}
static ostream&
operator<< (ostream& os, const check_suite_event& cs)
{
os << "action: " << cs.action << endl;
os << "<check_suite>" << endl << cs.check_suite;
os << "<repository>" << endl << cs.repository << endl;
return os;
}
|