diff options
| author | Boris Kolpackov <boris@codesynthesis.com> | 2024-10-15 08:42:33 +0200 |
|---|---|---|
| committer | Francois Kritzinger <francois@codesynthesis.com> | 2024-10-22 07:56:00 +0200 |
| commit | b6ac23972c0e4519830f02a270437304ed228d94 (patch) | |
| tree | 067e33268efcd956a8f67457af16489cc87f7b29 /mod | |
| parent | d3aa128583eab6afb92df329ca9ea27272394307 (diff) | |
Add "take 2" notes
Diffstat (limited to 'mod')
| -rw-r--r-- | mod/mod-ci-github.cxx | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index 990db63..48ae7e1 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -275,8 +275,8 @@ namespace brep // Note: "GitHub continues to add new event types and new actions to // existing event types." As a result we ignore known actions that we are // not interested in and log and ignore unknown actions. The thinking here - // is that we want be "notified" of new actions at which point we can decide - // whether to ignore them or to handle. + // is that we want be "notified" of new actions at which point we can + // decide whether to ignore them or to handle. // // @@ There is also check_run even (re-requested by user, either // individual check run or all the failed check runs). @@ -360,7 +360,7 @@ namespace brep // A pull request's head branch was updated from the base branch or // new commits were pushed to the head branch. (Note that there is // no equivalent event for the base branch. That case gets handled - // in handle_check_suite_request() instead.) + // in handle_check_suite_request() instead. @@ Not anymore.) // // Note that both cases are handled the same: we start a new CI // request which will be reported on the new commit id. @@ -372,6 +372,8 @@ namespace brep // Ignore the remaining actions by sending a 200 response with empty // body. // + // @@ Ignore known but log unknown, as in check_suite above? + // return true; } } @@ -487,6 +489,8 @@ namespace brep } } + // @@ Not anymore (and may not need separate create_pull_request_ci()). + // // The merge commits of any open pull requests with this branch as base // branch will now be out of date, and thus so will be their CI builds and // associated check runs (and, no, GitHub does not invalidate those CI |