diff options
| author | Francois Kritzinger <francois@codesynthesis.com> | 2024-04-30 14:38:08 +0200 |
|---|---|---|
| committer | Francois Kritzinger <francois@codesynthesis.com> | 2024-10-15 09:05:28 +0200 |
| commit | a05f09a08fe14f1c9a896975cfa3aed605574695 (patch) | |
| tree | 497d72b6b4f9d2e5b61e68e03b373ff1e80b431f /mod/mod-ci-github-gq.hxx | |
| parent | 47dd5a71330556342c765ba282d7acdec5c4d75a (diff) | |
Post-review changes
Diffstat (limited to 'mod/mod-ci-github-gq.hxx')
| -rw-r--r-- | mod/mod-ci-github-gq.hxx | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/mod/mod-ci-github-gq.hxx b/mod/mod-ci-github-gq.hxx index e8bb397..5ad77e1 100644 --- a/mod/mod-ci-github-gq.hxx +++ b/mod/mod-ci-github-gq.hxx @@ -26,6 +26,10 @@ namespace brep // Note: no details_url yet since there will be no entry in the build result // search page until the task starts building. // + // @@ TMP We only create multiple check runs in build_queued() so + // build_state is redundant. Maybe we should rename this + // gq_queue_check_runs()? + // bool gq_create_check_runs (const basic_mark& error, vector<check_run>& check_runs, @@ -38,14 +42,15 @@ namespace brep // state and the node ID. Return false and issue diagnostics if the request // failed. // - // The result_status is required if the build_state is built because GitHub - // does not allow a check run status of `completed` without a conclusion. @@ + // The gq_built_result is required if the build_state is built because + // GitHub does not allow a check run status of `completed` without at least + // a conclusion. // struct gq_built_result { string conclusion; string title; - string summmary; + string summary; }; bool @@ -64,8 +69,9 @@ namespace brep // with the new state. Return false and issue diagnostics if the request // failed. // - // The result_status is required if the build_state is built because GitHub - // does not allow a check run status of `completed` without a conclusion. @@ + // The gq_built_result is required if the build_state is built because + // GitHub does not allow a check run status of `completed` without at least + // a conclusion. // bool gq_update_check_run (const basic_mark& error, |