aboutsummaryrefslogtreecommitdiff
path: root/mod/mod-ci-github-gq.cxx
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-04-18 08:09:02 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-06-05 09:12:46 +0200
commit9bb4f1606d941aacc51626b370b84d976a836aba (patch)
tree96a8cd943f27c5950a3d4b483cef834fe767b969 /mod/mod-ci-github-gq.cxx
parent3f2a23ab62b5cbb940db7f925b3fff84d688285f (diff)
Fixes
Diffstat (limited to 'mod/mod-ci-github-gq.cxx')
-rw-r--r--mod/mod-ci-github-gq.cxx11
1 files changed, 4 insertions, 7 deletions
diff --git a/mod/mod-ci-github-gq.cxx b/mod/mod-ci-github-gq.cxx
index 4fe9190..b9b47c3 100644
--- a/mod/mod-ci-github-gq.cxx
+++ b/mod/mod-ci-github-gq.cxx
@@ -51,7 +51,7 @@ namespace brep
// @@ TODO: specify what parse_data may throw (probably only
// invalid_json_input).
//
- // @@ TODO errors comes before data in GitHub's responses.
+ // @@ TODO data comes before errors in GitHub's responses.
//
static void
gq_parse_response (json::parser& p,
@@ -200,7 +200,6 @@ namespace brep
static bool
gq_mutate_check_runs (vector<check_run>& crs,
const string& iat,
- const vector<reference_wrapper<const build>>& bs,
string rq,
build_state st,
const basic_mark& error) noexcept
@@ -230,14 +229,13 @@ namespace brep
{
rcrs = move (rs.check_runs);
- if (rcrs.size () == bs.size ())
+ if (rcrs.size () == crs.size ())
{
for (size_t i (0); i != rcrs.size (); ++i)
{
// Validate the check run in the response against the build.
//
const gh_check_run& rcr (rcrs[i]); // Received check run.
- const build& b (bs[i]);
build_state rst (gh_from_status (rcr.status)); // Received state.
@@ -408,7 +406,7 @@ namespace brep
string rq (gq_serialize_request (
gq_mutation_create_check_runs (rid, hs, bs, st, &bh)));
- return gq_mutate_check_runs (crs, iat, bs, move (rq), st, error);
+ return gq_mutate_check_runs (crs, iat, move (rq), st, error);
}
bool
@@ -435,7 +433,6 @@ namespace brep
const string& iat,
const string& rid,
const string& nid,
- const build& b,
build_state st,
const basic_mark& error)
{
@@ -444,7 +441,7 @@ namespace brep
vector<check_run> crs {move (cr)};
- bool r (gq_mutate_check_runs (crs, iat, {b}, move (rq), st, error));
+ bool r (gq_mutate_check_runs (crs, iat, move (rq), st, error));
cr = move (crs[0]);