aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2024-05-02 11:47:43 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-06-05 09:12:46 +0200
commit71d2f0ecf58f52cf37eaa987309c7ec64dbab6f6 (patch)
treee7daa24b3bb550c4de30af4a0c133fe2fa901cdb
parentabfeebfbb1912934954335d3c36baea12624c130 (diff)
Review
-rw-r--r--mod/mod-ci-github-gq.cxx24
-rw-r--r--mod/mod-ci-github.cxx5
2 files changed, 16 insertions, 13 deletions
diff --git a/mod/mod-ci-github-gq.cxx b/mod/mod-ci-github-gq.cxx
index d65d701..8e436e9 100644
--- a/mod/mod-ci-github-gq.cxx
+++ b/mod/mod-ci-github-gq.cxx
@@ -317,11 +317,12 @@ namespace brep
// Serialize `createCheckRun` mutations for one or more builds to GraphQL.
//
- // The `co` (conclusion) argument is required if the build_state is built
+ // The conclusion argument (`co`) is required if the build_state is built
// because GitHub does not allow a check run status of completed without a
// conclusion.
//
- // `du` can be empty for queued but not for the other states.
+ // The details URL argument (`du`) can be empty for queued but not for the
+ // other states.
//
static string
gq_mutation_create_check_runs (const string& ri, // Repository ID
@@ -440,7 +441,8 @@ namespace brep
// Empty details URL because it's not available until building.
//
- string rq (gq_serialize_request (
+ string rq (
+ gq_serialize_request (
gq_mutation_create_check_runs (rid, hs, "", crs, gh_to_status (st))));
return gq_mutate_check_runs (error, crs, iat, move (rq), st);
@@ -466,7 +468,8 @@ namespace brep
vector<check_run> crs {move (cr)};
- string rq (gq_serialize_request (
+ string rq (
+ gq_serialize_request (
gq_mutation_create_check_runs (rid,
hs,
du,
@@ -491,16 +494,17 @@ namespace brep
build_state st,
optional<gq_built_result> br)
{
- // Must have a result if state is built.
+ // Must have a result if state is built. @@ du?
//
assert (st != build_state::built || br);
string rq (
- gq_serialize_request (gq_mutation_update_check_run (rid,
- nid,
- du,
- gh_to_status (st),
- move (br))));
+ gq_serialize_request (
+ gq_mutation_update_check_run (rid,
+ nid,
+ du,
+ gh_to_status (st),
+ move (br))));
vector<check_run> crs {move (cr)};
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index 52431d2..9c084ba 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -869,7 +869,7 @@ namespace brep
iat->token,
sd.repository_id,
*cr.node_id,
- "", // Don't update details_url again.
+ "", // Don't update details_url again. @@
build_state::built,
move (br)))
{
@@ -959,8 +959,7 @@ namespace brep
"&tg=" + mime_url_encode (b.target.string ()) +
"&tc=" + mime_url_encode (b.target_config_name) +
"&pc=" + mime_url_encode (b.package_config_name) +
- "&th=" + mime_url_encode (b.toolchain_version.string ()) +
- "&rs=*";
+ "&th=" + mime_url_encode (b.toolchain_version.string ());
}
optional<string> ci_github::