diff options
| author | Karen Arutyunov <karen@codesynthesis.com> | 2023-07-28 14:18:53 +0300 |
|---|---|---|
| committer | Karen Arutyunov <karen@codesynthesis.com> | 2023-07-28 14:18:53 +0300 |
| commit | da6d239d0771142b795d18105aac8d130e85c5ba (patch) | |
| tree | dfa196b7933733b1b6b6aa4708c95b2f7761ac38 /bpkg/pkg-configure.cxx | |
| parent | c4c3ab9a49d824eb64dbf3d1e1c6c079ffff92cb (diff) | |
Add another test case for pkg_configure() flaws
Diffstat (limited to 'bpkg/pkg-configure.cxx')
| -rw-r--r-- | bpkg/pkg-configure.cxx | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/bpkg/pkg-configure.cxx b/bpkg/pkg-configure.cxx index 5bb7dfa..57ac5ac 100644 --- a/bpkg/pkg-configure.cxx +++ b/bpkg/pkg-configure.cxx @@ -99,17 +99,20 @@ namespace bpkg // // @@ It seems there is a hole in the reconfiguration mode: // - // foo -> libfoo {require {config.libfoo.proto=1} + // foo -> libfoo {prefer {config.libfoo.proto=1} accept(true) // reflect {config.foo.reflect=1}} | - // libfoo {require {config.libfoo.proto=2} + // libfoo {prefer {config.libfoo.proto=2} accept(true) // reflect {config.foo.reflect=2}} - // -> libbar {require {config.libfoo.proto=2}} + // -> libbar {prefer {config.libbar.proto=$config.libfoo.proto} + // accept (config.libbar.proto=2)} // -> libbaz // - // foo is configured with config.foo.reflect=2 + // foo is configured with config.foo.reflect=2 initially. // - // If afterwords libbaz is upgraded, the foo is - // reconfigured with config.foo.reflect=1 + // If afterwords libbaz is upgraded, the foo is reconfigured with + // config.foo.reflect=1 just because we erroneously pick the first + // libfoo alternative (which has been banned by libbar accept clause + // on the previous pkg-build run during negotiation). // // It feels more and more that the proper solution here is to go // "nuclear" and to always "upgrade" re-configuration for a package |