aboutsummaryrefslogtreecommitdiff
path: root/bbot/worker/worker.cxx
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2020-10-27 15:49:56 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2020-10-27 15:50:56 +0200
commitf5ae09e7b1b6e38502e8532e1801076253f450b2 (patch)
tree580a2f1065db9df3065c6c65bff7237cdedc27f3 /bbot/worker/worker.cxx
parentb9456fe43f5b1d534d3345a6c6f84534e11b7fd3 (diff)
Add comment on why uploading result via temporary file
Diffstat (limited to 'bbot/worker/worker.cxx')
-rw-r--r--bbot/worker/worker.cxx6
1 files changed, 6 insertions, 0 deletions
diff --git a/bbot/worker/worker.cxx b/bbot/worker/worker.cxx
index 0489822..3f7b941 100644
--- a/bbot/worker/worker.cxx
+++ b/bbot/worker/worker.cxx
@@ -357,6 +357,12 @@ upload_manifest (tracer& trace,
{
try
{
+ // Piping the data directly into curl's stdin sometimes results in the
+ // broken pipe error on the client and partial/truncated upload on the
+ // server. This happens quite regularly on older Linux distributions
+ // (e.g., Debian 8, Ubuntu 16.04) but also sometimes on Windows. On the
+ // other hand, uploading from a file appears to work reliably.
+ //
#if 0
tftp_curl c (trace,
path ("-"),