From b99c6823a7f35b2914d52fdd435488ce2f40872a Mon Sep 17 00:00:00 2001 From: Karen Arutyunov Date: Tue, 1 Nov 2022 20:50:55 +0300 Subject: Fix getline_non_blocking() and add test --- libbutl/fdstream.cxx | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'libbutl') diff --git a/libbutl/fdstream.cxx b/libbutl/fdstream.cxx index b4fe4b6..809178a 100644 --- a/libbutl/fdstream.cxx +++ b/libbutl/fdstream.cxx @@ -877,9 +877,9 @@ namespace butl } bool - getline_non_blocking (ifdstream& is, std::string& l, char delim) + getline_non_blocking (ifdstream& is, string& l, char delim) { - assert (!is.blocking () && (is.exceptions () &ifdstream::badbit) != 0); + assert (!is.blocking () && (is.exceptions () & ifdstream::badbit) != 0); fdstreambuf& sb (*static_cast (is.rdbuf ())); @@ -914,12 +914,15 @@ namespace butl // 0 -- blocked before encountering delimiter/EOF. // >0 -- encountered the delimiter. // - if (s == -1 && l.empty ()) + if (s == -1) { + is.setstate (ifdstream::eofbit); + // If we couldn't extract anything, not even the delimiter, then this is // a failure per the getline() interface. // - is.setstate (ifdstream::failbit); + if (l.empty ()) + is.setstate (ifdstream::failbit); } return s != 0; -- cgit v1.1