From f29c9a5a0cdca0205f98d55ad20d1145295db126 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Mon, 23 Jan 2017 12:12:04 +0200 Subject: Minor changes --- butl/base64.cxx | 2 +- butl/diagnostics | 6 +++++- butl/path | 4 ++-- butl/small-vector | 3 ++- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/butl/base64.cxx b/butl/base64.cxx index 3286b19..ee44700 100644 --- a/butl/base64.cxx +++ b/butl/base64.cxx @@ -14,7 +14,7 @@ using namespace std; namespace butl { - static const char* codes = + static const char codes[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; // base64-encode the data in the iterator range [i, e). Write the encoded diff --git a/butl/diagnostics b/butl/diagnostics index 60e8538..da24c69 100644 --- a/butl/diagnostics +++ b/butl/diagnostics @@ -18,7 +18,11 @@ namespace butl { // Diagnostic facility base infrastructure. // - LIBBUTL_EXPORT extern std::ostream* diag_stream; // std::cerr by default. + + // Diagnostics destination stream (std::cerr by default). Note that its + // modification is not MT-safe. + // + LIBBUTL_EXPORT extern std::ostream* diag_stream; struct diag_record; template struct diag_prologue; diff --git a/butl/path b/butl/path index 3a2335e..da36770 100644 --- a/butl/path +++ b/butl/path @@ -319,8 +319,8 @@ namespace butl // Return a temporary name. The name is constructed by starting with the // prefix followed by the process id following by a unique counter value - // inside the process. Throw std::system_error to report the underlying OS - // errors. + // inside the process (MT-safe). Throw std::system_error to report the + // underlying OS errors. // static string_type temp_name (string_type const& prefix); diff --git a/butl/small-vector b/butl/small-vector index 5bfbd17..3e50735 100644 --- a/butl/small-vector +++ b/butl/small-vector @@ -230,7 +230,8 @@ namespace butl // VC's implementation of operator=(&&) (both 14 and 15) frees the // memory and then reallocated with capacity equal to v.size(). This is // clearly sub-optimal (the existing buffer could be reused) so we hope - // this will be fixed eventually (VSO#367146). + // this will be fixed eventually (VSO#367146; reportedly fixed for + // VC15U1). // #if defined(_MSC_VER) && _MSC_VER <= 1910 if (v.size () < N) -- cgit v1.1