Make template definition available in all translation units where used

We were trying to be clever but GCC 10's IPA-SRA optimization didn't like it.

1 files changed, 35 insertions, 0 deletions

diff --git a/libbuild2/cc/common.txx b/libbuild2/cc/common.txx
new file mode 100644
index 0000000..bfbc52c
--- /dev/null
+++ b/libbuild2/cc/common.txx
@@ -0,0 +1,35 @@
+// file      : libbuild2/cc/common.txx -*- C++ -*-
+// license   : MIT; see accompanying LICENSE file
+
+namespace build2
+{
+  namespace cc
+  {
+    // Insert a target "tagging" it with the specified process path and
+    // verifying that it already exists if requested. Return the lock.
+    //
+    template <typename T>
+    ulock common::
+    insert_library (context& ctx,
+                    T*& r,
+                    string name,
+                    dir_path dir,
+                    const process_path& out,
+                    optional<string> ext,
+                    bool exist,
+                    tracer& trace)
+    {
+      auto p (ctx.targets.insert_locked (T::static_type,
+                                         move (dir),
+                                         path_cast<dir_path> (out.effect),
+                                         name,
+                                         move (ext),
+                                         true, // Implied.
+                                         trace));
+
+      assert (!exist || !p.second.owns_lock ());
+      r = &p.first.template as<T> ();
+      return move (p.second);
+    }
+  }
+}