1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
|
// file : mod/mod-ci-github.cxx -*- C++ -*-
// license : MIT; see accompanying LICENSE file
#include <mod/mod-ci-github.hxx>
#include <libbutl/curl.hxx>
#include <libbutl/json/parser.hxx>
#include <mod/jwt.hxx>
#include <mod/module-options.hxx>
#include <stdexcept>
#include <iostream>
// @@ TODO
//
// Building CI checks with a GitHub App
// https://docs.github.com/en/apps/creating-github-apps/writing-code-for-a-github-app/building-ci-checks-with-a-github-app
//
// @@ TODO Best practices
//
// Webhooks:
// https://docs.github.com/en/webhooks/using-webhooks/best-practices-for-using-webhooks
//
// REST API:
// https://docs.github.com/en/rest/using-the-rest-api/best-practices-for-using-the-rest-api?apiVersion=2022-11-28
//
// Creating an App:
// https://docs.github.com/en/apps/creating-github-apps/about-creating-github-apps/best-practices-for-creating-a-github-app
//
// Use a webhook secret to ensure request is coming from Github. HMAC:
// https://en.wikipedia.org/wiki/HMAC#Definition. A suitable implementation
// is provided by OpenSSL.
using namespace std;
using namespace butl;
using namespace web;
using namespace brep::cli;
namespace brep
{
using namespace gh;
ci_github::
ci_github (const ci_github& r)
: handler (r),
options_ (r.initialized_ ? r.options_ : nullptr)
{
}
void ci_github::
init (scanner& s)
{
options_ = make_shared<options::ci_github> (
s, unknown_mode::fail, unknown_mode::fail);
}
bool ci_github::
handle (request& rq, response&)
{
using namespace bpkg;
HANDLER_DIAG;
// @@ TODO: disable service if HMAC is not specified in config.
//
if (false)
throw invalid_request (404, "CI request submission disabled");
// Process headers.
//
string event;
// @@ TMP Shouldn't we also error<< in some of these header problem cases?
//
{
bool content_type (false);
for (const name_value& h: rq.headers ())
{
if (icasecmp (h.name, "x-github-delivery") == 0)
{
// @@ TODO Check that delivery UUID has not been received before
// (replay attack).
}
else if (icasecmp (h.name, "content-type") == 0)
{
if (!h.value)
throw invalid_request (400, "missing content-type value");
if (icasecmp (*h.value, "application/json") != 0)
{
throw invalid_request (400,
"invalid content-type value: '" + *h.value +
'\'');
}
content_type = true;
}
else if (icasecmp (h.name, "x-github-event") == 0)
{
if (!h.value)
throw invalid_request (400, "missing x-github-event value");
event = *h.value;
}
}
if (!content_type)
throw invalid_request (400, "missing content-type header");
if (event.empty ())
throw invalid_request (400, "missing x-github-event header");
}
// There is an event (specified in the x-github-event header) and each event
// contains a bunch of actions (specified in the JSON request body).
//
// Note: "GitHub continues to add new event types and new actions to
// existing event types." As a result we ignore known actions that we are
// not interested in and log and ignore unknown actions. The thinking here
// is that we want be "notified" of new actions at which point we can decide
// whether to ignore them or to handle.
//
if (event == "check_suite")
{
check_suite_event cs;
try
{
json::parser p (rq.content (64 * 1024), "check_suite webhook");
cs = check_suite_event (p);
}
catch (const json::invalid_json_input& e)
{
string m ("malformed JSON in " + e.name + " request body");
error << m << ", line: " << e.line << ", column: " << e.column
<< ", byte offset: " << e.position << ", error: " << e;
throw invalid_request (400, move (m));
}
if (cs.action == "requested")
{
return handle_check_suite_request (move (cs));
}
else if (cs.action == "rerequested")
{
// Someone manually requested to re-run the check runs in this check
// suite. Treat as a new request.
//
return handle_check_suite_request (move (cs));
}
else if (cs.action == "completed")
{
// GitHub thinks that "all the check runs in this check suite have
// completed and a conclusion is available". Looks like this one we
// ignore?
//
// @@ TODO What if our bookkeeping says otherwise? See conclusion
// field which includes timedout. Need to come back to this once
// have the "happy path" implemented.
//
return true;
}
else
{
// Ignore unknown actions by sending a 200 response with empty body
// but also log as an error since we want to notice new actions.
//
error << "unknown action '" << cs.action << "' in check_suite webhook";
return true;
}
}
else if (event == "pull_request")
{
// @@ TODO
throw invalid_request (501, "pull request events not implemented yet");
}
else
{
// Log to investigate.
//
error << "unexpected event '" << event << "'";
throw invalid_request (400, "unexpected event: '" + event + "'");
}
}
bool ci_github::
handle_check_suite_request (check_suite_event cs) const
{
cout << "<check_suite webhook>" << endl << cs << endl;
installation_access_token iat (
obtain_installation_access_token (cs.installation.id, generate_jwt ()));
cout << endl << "<installation_access_token>" << endl << iat << endl;
return true;
}
// Send a POST request to the GitHub API endpoint `ep`, parse GitHub's JSON
// response into `rs` (only for 200 codes), and return the HTTP status code.
//
// The endpoint `ep` should not have a leading slash.
//
// Pass additional HTTP headers in `hdrs`. For example:
//
// "HeaderName: header value"
//
// Throw invalid_argument if unable to parse the response headers,
// invalid_json_input (derived from invalid_argument) if unable to parse the
// response body, and system_error in other cases.
//
template<typename T>
static uint16_t
github_post (T& rs, const string& ep, const strings& hdrs)
{
// Convert the header values to curl header option/value pairs.
//
strings hdr_opts;
for (const string& h: hdrs)
{
hdr_opts.push_back ("--header");
hdr_opts.push_back (h);
}
// Run curl.
//
try
{
// Pass --include to print the HTTP status line (followed by the response
// headers) so that we can get the response status code.
//
// Suppress the --fail option which causes curl to exit with status 22
// in case of an error HTTP response status code (>= 400) otherwise we
// can't get the status code.
//
// Note that butl::curl also adds --location to make curl follow redirects
// (which is recommended by GitHub).
//
// The API version `2022-11-28` is the only one currently supported. If
// the X-GitHub-Api-Version header is not passed this version will be
// chosen by default.
//
fdpipe errp (fdopen_pipe ()); // stderr pipe.
curl c (nullfd,
path ("-"), // Write response to curl::in.
process::pipe (errp.in.get (), move (errp.out)),
curl::post,
curl::flags::no_fail,
"https://api.github.com/" + ep,
"--no-fail", // Don't fail if response status code >= 400.
"--include", // Output response headers for status code.
"--header", "Accept: application/vnd.github+json",
"--header", "X-GitHub-Api-Version: 2022-11-28",
move (hdr_opts));
ifdstream err (move (errp.in));
// Parse the HTTP response.
//
int sc; // Status code.
try
{
// Note: re-open in/out so that they get automatically closed on
// exception.
//
ifdstream in (c.in.release (), fdstream_mode::skip);
sc = curl::read_http_status (in).code; // May throw invalid_argument.
// Parse the response body if the status code is in the 200 range.
//
if (sc >= 200 && sc < 300)
{
// Use endpoint name as input name (useful to have it propagated
// in exceptions).
//
json::parser p (in, ep /* name */);
rs = T (p);
}
in.close ();
}
catch (const io_error& e)
{
// If the process exits with non-zero status, assume the IO error is due
// to that and fall through.
//
if (c.wait ())
{
throw_generic_error (
e.code ().value (),
(string ("unable to read curl stdout: ") + e.what ()).c_str ());
}
}
catch (const json::invalid_json_input&)
{
// If the process exits with non-zero status, assume the JSON error is
// due to that and fall through.
//
if (c.wait ())
throw;
}
if (!c.wait ())
{
string et (err.read_text ());
throw_generic_error (EINVAL,
("non-zero curl exit status: " + et).c_str ());
}
err.close ();
return sc;
}
catch (const process_error& e)
{
throw_generic_error (
e.code ().value (),
(string ("unable to execute curl:") + e.what ()).c_str ());
}
catch (const io_error& e)
{
// Unable to read diagnostics from stderr.
//
throw_generic_error (
e.code ().value (),
(string ("unable to read curl stderr : ") + e.what ()).c_str ());
}
}
string ci_github::
generate_jwt () const
{
string jwt;
try
{
// Set token's "issued at" time 60 seconds in the past to combat clock
// drift (as recommended by GitHub).
//
jwt = brep::generate_jwt (
*options_,
options_->ci_github_app_private_key (),
to_string (options_->ci_github_app_id ()),
chrono::seconds (options_->ci_github_jwt_validity_period ()),
chrono::seconds (60));
cout << "JWT: " << jwt << endl;
}
catch (const system_error& e)
{
HANDLER_DIAG;
fail << "unable to generate JWT (errno=" << e.code () << "): " << e;
}
return jwt;
}
// There are three types of GitHub API authentication:
//
// 1) Authenticating as an app. Used to access parts of the API concerning
// the app itself such as getting the list of installations. (Need to
// authenticate as an app as part of authenticating as an app
// installation.)
//
// 2) Authenticating as an app installation (on a user or organisation
// account). Used to access resources belonging to the user/repository
// or organisation the app is installed in.
//
// 3) Authenticating as a user. Used to perform actions as the user.
//
// We need to authenticate as an app installation (2).
//
// How to authenticate as an app installation
//
// Reference:
// https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation
//
// The final authentication token we need is an installation access token
// (IAT), valid for one hour, which we will pass in the `Authentication`
// header of our Github API requests:
//
// Authorization: Bearer <INSTALLATION_ACCESS_TOKEN>
//
// To generate an IAT:
//
// - Generate a JSON Web Token (JWT)
//
// - Get the installation ID. This will be included in the webhook request
// in our case
//
// - Send a POST to /app/installations/<INSTALLATION_ID>/access_tokens which
// includes the JWT (`Authorization: Bearer <JWT>`). The response will
// include the IAT. Can pass the name of the repository included in the
// webhook request to restrict access, otherwise we get access to all
// repos covered by the installation if installed on an organisation for
// example.
//
installation_access_token ci_github::
obtain_installation_access_token (uint64_t iid, string jwt) const
{
HANDLER_DIAG;
installation_access_token iat;
try
{
// API endpoint.
//
string ep ("app/installations/" + to_string (iid) + "/access_tokens");
int sc (github_post (iat, ep, strings {"Authorization: Bearer " + jwt}));
// Possible response status codes from the access_tokens endpoint:
//
// 201 Created
// 401 Requires authentication
// 403 Forbidden
// 404 Resource not found
// 422 Validation failed, or the endpoint has been spammed.
//
// Note that the payloads of non-201 status codes are undocumented.
//
if (sc != 201)
{
fail << "unable to get installation access token: "
<< "error HTTP response status " << sc;
}
}
catch (const json::invalid_json_input& e)
{
// Note: e.name is the GitHub API endpoint.
//
fail << "malformed JSON in response from " << e.name << ", line: "
<< e.line << ", column: " << e.column << ", byte offset: "
<< e.position << ", error: " << e;
}
catch (const invalid_argument& e)
{
fail << "malformed header(s) in response: " << e;
}
catch (const system_error& e)
{
fail << "unable to get installation access token (errno=" << e.code ()
<< "): " << e.what ();
}
return iat;
}
// The rest is GitHub request/response type parsing and printing.
//
using event = json::event;
// Throw invalid_json_input when a required member `m` is missing from a
// JSON object `o`.
//
[[noreturn]] static void
missing_member (const json::parser& p, const char* o, const char* m)
{
throw json::invalid_json_input (
p.input_name,
p.line (), p.column (), p.position (),
o + string (" object is missing member '") + m + '\'');
}
// check_suite
//
gh::check_suite::
check_suite (json::parser& p)
{
p.next_expect (event::begin_object);
bool i (false), hb (false), hs (false), bf (false), at (false);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
auto c = [&p] (bool& v, const char* s)
{
return p.name () == s ? (v = true) : false;
};
if (c (i, "id")) id = p.next_expect_number<uint64_t> ();
else if (c (hb, "head_branch")) head_branch = p.next_expect_string ();
else if (c (hs, "head_sha")) head_sha = p.next_expect_string ();
else if (c (bf, "before")) before = p.next_expect_string ();
else if (c (at, "after")) after = p.next_expect_string ();
else p.next_expect_value_skip ();
}
if (!i) missing_member (p, "check_suite", "id");
if (!hb) missing_member (p, "check_suite", "head_branch");
if (!hs) missing_member (p, "check_suite", "head_sha");
if (!bf) missing_member (p, "check_suite", "before");
if (!at) missing_member (p, "check_suite", "after");
}
static ostream&
gh::operator<< (ostream& os, const check_suite& cs)
{
os << "id: " << cs.id << endl
<< "head_branch: " << cs.head_branch << endl
<< "head_sha: " << cs.head_sha << endl
<< "before: " << cs.before << endl
<< "after: " << cs.after << endl;
return os;
}
// repository
//
gh::repository::
repository (json::parser& p)
{
p.next_expect (event::begin_object);
bool nm (false), fn (false), db (false);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
auto c = [&p] (bool& v, const char* s)
{
return p.name () == s ? (v = true) : false;
};
if (c (nm, "name")) name = p.next_expect_string ();
else if (c (fn, "full_name")) full_name = p.next_expect_string ();
else if (c (db, "default_branch")) default_branch = p.next_expect_string ();
else p.next_expect_value_skip ();
}
if (!nm) missing_member (p, "repository", "name");
if (!fn) missing_member (p, "repository", "full_name");
if (!db) missing_member (p, "repository", "default_branch");
}
static ostream&
gh::operator<< (ostream& os, const repository& rep)
{
os << "name: " << rep.name << endl
<< "full_name: " << rep.full_name << endl
<< "default_branch: " << rep.default_branch << endl;
return os;
}
// installation
//
gh::installation::
installation (json::parser& p)
{
p.next_expect (event::begin_object);
bool i (false);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
auto c = [&p] (bool& v, const char* s)
{
return p.name () == s ? (v = true) : false;
};
if (c (i, "id")) id = p.next_expect_number<uint64_t> ();
else p.next_expect_value_skip ();
}
if (!i) missing_member (p, "installation", "id");
}
static ostream&
gh::operator<< (ostream& os, const installation& i)
{
os << "id: " << i.id << endl;
return os;
}
// check_suite_event
//
gh::check_suite_event::
check_suite_event (json::parser& p)
{
p.next_expect (event::begin_object);
bool ac (false), cs (false), rp (false), in (false);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
auto c = [&p] (bool& v, const char* s)
{
return p.name () == s ? (v = true) : false;
};
if (c (ac, "action")) action = p.next_expect_string ();
else if (c (cs, "check_suite")) check_suite = gh::check_suite (p);
else if (c (rp, "repository")) repository = gh::repository (p);
else if (c (in, "installation")) installation = gh::installation (p);
else p.next_expect_value_skip ();
}
if (!ac) missing_member (p, "check_suite_event", "action");
if (!cs) missing_member (p, "check_suite_event", "check_suite");
if (!rp) missing_member (p, "check_suite_event", "repository");
if (!in) missing_member (p, "check_suite_event", "installation");
}
static ostream&
gh::operator<< (ostream& os, const check_suite_event& cs)
{
os << "action: " << cs.action << endl;
os << "<check_suite>" << endl << cs.check_suite;
os << "<repository>" << endl << cs.repository;
os << "<installation>" << endl << cs.installation;
return os;
}
// installation_access_token
//
// Example JSON:
//
// {
// "token": "ghs_Py7TPcsmsITeVCAWeVtD8RQs8eSos71O5Nzp",
// "expires_at": "2024-02-15T16:16:38Z",
// ...
// }
//
gh::installation_access_token::
installation_access_token (json::parser& p)
{
p.next_expect (event::begin_object);
bool tk (false), ea (false);
// Skip unknown/uninteresting members.
//
while (p.next_expect (event::name, event::end_object))
{
auto c = [&p] (bool& v, const char* s)
{
return p.name () == s ? (v = true) : false;
};
if (c (tk, "token")) token = p.next_expect_string ();
else if (c (ea, "expires_at"))
{
const string& s (p.next_expect_string ());
expires_at = from_string (s.c_str (), "%Y-%m-%dT%TZ", false /* local */);
}
else p.next_expect_value_skip ();
}
if (!tk) missing_member (p, "installation_access_token", "token");
if (!ea) missing_member (p, "installation_access_token", "expires_at");
}
static ostream&
gh::operator<< (ostream& os, const installation_access_token& t)
{
os << "token: " << t.token << endl;
os << "expires_at: ";
butl::operator<< (os, t.expires_at) << endl;
return os;
}
}
|