From 80626fde3bb2a6b013d4a3dd75eab55c6913f64e Mon Sep 17 00:00:00 2001
From: Boris Kolpackov <boris@codesynthesis.com>
Date: Wed, 21 Feb 2024 12:38:49 +0200
Subject: Review: JWT

---
 mod/jwt.cxx           | 47 ++++++++++++++++++++++++++++-------------------
 mod/mod-ci-github.cxx |  5 ++++-
 mod/module.cli        |  2 +-
 3 files changed, 33 insertions(+), 21 deletions(-)

(limited to 'mod')

diff --git a/mod/jwt.cxx b/mod/jwt.cxx
index e70752e..0c9c1f6 100644
--- a/mod/jwt.cxx
+++ b/mod/jwt.cxx
@@ -122,15 +122,19 @@ gen_jwt (const options::openssl_options& o,
                 process_env (o.openssl (), o.openssl_envvar ()),
                 "dgst", o.openssl_option (), "-sha256", "-sign", pk);
 
+    ifdstream err (move (errp.in));
+
     vector<char> bs; // Binary signature (openssl output).
     string et;       // Openssl stderr text.
     try
     {
       // In case of exception, skip and close input after output.
       //
+      // Note: re-open in/out so that they get automaitcally closed on
+      // exception.
+      //
       ifdstream in (os.in.release (), fdstream_mode::skip);
       ofdstream out (os.out.release ());
-      ifdstream err (move (errp.in));
 
       // Write the concatenated header and payload to openssl's input.
       //
@@ -141,40 +145,45 @@ gen_jwt (const options::openssl_options& o,
       //
       bs = in.read_binary ();
       in.close ();
-
-      if (!os.wait ())
-        et = err.read_text ();
-
-      err.close ();
     }
     catch (const io_error& e)
     {
-      // IO failure, child exit status doesn't matter. Just wait for the
-      // process completion and throw.
+      // If the process exits with non-zero status, assume the IO error is due
+      // to that and fall through.
       //
-      os.wait ();
-
-      throw_generic_error (e.code ().value (),
-                           ("unable to communicate with " +
-                            o.openssl ().string () + ": " + e.what ())
-                               .c_str ());
+      if (os.wait ())
+      {
+        throw_generic_error (
+          e.code ().value (),
+          ("unable to read/write openssl stdout/stdin: " + e.what ()).c_str ());
+      }
     }
 
     if (!os.wait ())
     {
+      et = err.read_text ();
       throw_generic_error (
-          EINVAL,
-          (o.openssl ().string () + " failed: " + et).c_str ());
+        EINVAL,
+        ("non-zero openssl exit status: " + et).c_str ());
     }
 
+    err.close ();
+
     s = base64url_encode (bs);
   }
   catch (const process_error& e)
   {
     throw_generic_error (
-        e.code ().value (),
-        ("unable to execute " + o.openssl ().string () + ": " + e.what ())
-            .c_str ());
+      e.code ().value (),
+      ("unable to execute openssl: " + e.what ()).c_str ());
+  }
+  catch (const io_error& e)
+  {
+    // Unable to read diagnostics from stderr.
+    //
+    throw_generic_error (
+      e.code ().value (),
+      ("unable to read openssl stderr : " + e.what ()).c_str ());
   }
 
   return h + '.' + p + '.' + s; // Return the token.
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index 13e6d32..396e732 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -390,6 +390,8 @@ handle (request& rq, response& rs)
       //  @@ TMP Actually I was wrong, these do not end up in any logs. Pretty
       //         sure I saw them go there but they're definitely not anymore.
       //
+      //     See how it's done in other modules and do the same.
+      //
       throw invalid_request (400, "malformed JSON in request body");
     }
 
@@ -431,7 +433,8 @@ handle (request& rq, response& rs)
     }
     catch (const system_error& e)
     {
-      fail << "unable to generate JWT: [" << e.code () << "] " << e.what ();
+      fail << "unable to generate JWT (errno=" << e.code () << "): "
+           << e.what ();
     }
 
     // Authenticate to GitHub as an app installation.
diff --git a/mod/module.cli b/mod/module.cli
index 4f37c29..9b17a2c 100644
--- a/mod/module.cli
+++ b/mod/module.cli
@@ -869,7 +869,7 @@ namespace brep
          the GitHub app's settings."
       }
 
-      uint16_t ci-github-jwt-validity-period = 10
+      uint16_t ci-github-jwt-validity-period = 10 // @@ Seconds.
       {
         "<minutes>",
         "The number of minutes a JWT (authentication token) should be valid for.
-- 
cgit v1.1