From cfdf2b202d36d2332a37af51c770054bfb3d49c8 Mon Sep 17 00:00:00 2001 From: Francois Kritzinger Date: Thu, 19 Dec 2024 16:15:26 +0200 Subject: ci-github: Add questions/TODOs --- mod/mod-ci-github.cxx | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'mod/mod-ci-github.cxx') diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index 773ca5f..9514fb8 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -960,6 +960,11 @@ namespace brep { if (d->archived) // Tenant is archived { + // @@ TODO Why aren't we updating instead of creating? The node ids + // are in the service data (which is still available after + // archiving, which I didn't know). And both CRs should already + // be built. + // Fail (re-create) the check runs. // optional iat (get_iat ()); @@ -1054,6 +1059,11 @@ namespace brep // Fail if it's the conclusion check run that is being re-requested. // + // @@ TMP When user selects re-run all failed checks we receive multiple + // check_runs, one of which is for the CCR. We then update it with the + // error message, triggering another check_suite(completed) right after + // all of the check_runs(rerequested). + // if (cr.check_run.name == conclusion_check_run_name) { l3 ([&]{trace << "re-requested conclusion check_run";}); -- cgit v1.1