From 4e96560c1780737cb33891eba86ac9b6c4fbc148 Mon Sep 17 00:00:00 2001 From: Boris Kolpackov Date: Tue, 30 Apr 2024 12:25:48 +0200 Subject: Review --- mod/mod-ci-github.cxx | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'mod/mod-ci-github.cxx') diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index 4ee3cc0..29097be 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -704,6 +704,8 @@ namespace brep // if (iat != nullptr) { + // @@ TODO: send timestamp so that build duration is accurate? + if (gq_update_check_run (error, *cr, iat->token, @@ -845,6 +847,10 @@ namespace brep // if (iat != nullptr) { + // @@ Maybe we should map status here according to warning_success + // instead of passing it to gq_*() functions? Let's see how we handle + // the report. + if (cr.node_id) { // Update existing check run to built. -- cgit v1.1