diff options
Diffstat (limited to 'mod/mod-ci-github-gh.hxx')
| -rw-r--r-- | mod/mod-ci-github-gh.hxx | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/mod/mod-ci-github-gh.hxx b/mod/mod-ci-github-gh.hxx index eeda871..101e240 100644 --- a/mod/mod-ci-github-gh.hxx +++ b/mod/mod-ci-github-gh.hxx @@ -21,8 +21,6 @@ namespace butl namespace brep { - // @@@ Check if any data members are unused (once the dust settles). - using build_queued_hints = tenant_service_build_queued::build_queued_hints; // GitHub request/response types (all start with gh_). @@ -87,15 +85,22 @@ namespace brep string node_id; unsigned int number; + // Note that some of these base/head members are only used for logging. + // // @@ TMP The unused base/head members may be useful for trace output when // we receive the pull_request webhook. + // + // @@ Seems worth keeping. Example from logs: + // + // base: { path: francoisk/libb2, ref: master, sha: 78b61bd3ce7b2b46bf7277446571d1ddd5b36a82 } + // head: { path: francoisk/libb2, ref: dev, sha: 32561c28ef039545d17d10bf10fad7babcf9c33a } string base_path; // Repository path (<org>/<repo>) under github.com. - string base_ref; // @@ TODO Remove if remains unused. - string base_sha; // @@ TODO Remove if remains unused. + string base_ref; + string base_sha; string head_path; - string head_ref; // @@ TODO Remove if remains unused. + string head_ref; string head_sha; explicit @@ -133,7 +138,6 @@ namespace brep struct gh_repository { string node_id; - string name; string path; // Repository path (<org>/<repo>) under github.com. string clone_url; |