diff options
| -rw-r--r-- | INSTALL-GITHUB-DEV | 12 | ||||
| -rw-r--r-- | mod/mod-ci-github.cxx | 4 |
2 files changed, 12 insertions, 4 deletions
diff --git a/INSTALL-GITHUB-DEV b/INSTALL-GITHUB-DEV index c28ce06..dfcbfe7 100644 --- a/INSTALL-GITHUB-DEV +++ b/INSTALL-GITHUB-DEV @@ -128,11 +128,15 @@ aspects but can't redeliver webhooks. - Branch push (BP). - - Success (also observe check run state transitions). - - Failure (also observe check run state transitions). + - Success (observe check runs state transitions). Test with 2 build configs. + - Failure (observe check runs state transitions). + - Push new commit to branch. - Re-requested check suite. - - Re-requested check run. + - Re-requested check run (observe check run state transitions). + - Re-requested check run but tenant archived. - Cancel previous check suite on forced push. + - Head commit shared with another BP. + - Cancel previous check suite on forced push with shared previous commit. - Pull request (PR). @@ -140,6 +144,7 @@ aspects but can't redeliver webhooks. - Success. - Failure. + - Push new commit to head. - Re-requested check suite. - Re-requested check run. - Head shared with BP. @@ -149,6 +154,7 @@ aspects but can't redeliver webhooks. - Success. - Failure. + - Push new commit to head. - Re-requested check suite. - Re-requested check run. - Head shared with another remote PR. diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index 854ce7e..1a1329d 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -277,7 +277,7 @@ namespace brep // Note: "GitHub continues to add new event types and new actions to // existing event types." As a result we ignore known actions that we are // not interested in and log and ignore unknown actions. The thinking here - // is that we want be "notified" of new actions at which point we can + // is that we want to be "notified" of new actions at which point we can // decide whether to ignore them or to handle. // if (event == "check_suite") @@ -513,6 +513,8 @@ namespace brep throw invalid_request (400, move (m)); } + // Note that the push request event has no action. + // return handle_push_request (move (ps)); } else |