aboutsummaryrefslogtreecommitdiff
path: root/mod/mod-ci-github.cxx
diff options
context:
space:
mode:
authorBoris Kolpackov <boris@codesynthesis.com>2024-10-31 10:24:03 +0200
committerBoris Kolpackov <boris@codesynthesis.com>2024-10-31 10:24:03 +0200
commite5b50ebc00573189f258befcd0c6b17b7d78ef8a (patch)
tree802c3bfffd55b1e3d8046d35a92e7e48b74f330b /mod/mod-ci-github.cxx
parent1b27c519ff3ff8a379cbb6e47c3d9094f1a99237 (diff)
Review
Diffstat (limited to 'mod/mod-ci-github.cxx')
-rw-r--r--mod/mod-ci-github.cxx10
1 files changed, 6 insertions, 4 deletions
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index fb4b29d..5417f7c 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -988,7 +988,7 @@ namespace brep
// Load the tenant, which is essentially the same for both branch push and
// PR. The overall plan is as follows:
//
- // - Create synthetic conclusion check run with the building state. If
+ // - Create synthetic conclusion check run with the in-progress state. If
// unable to, get called again to re-try.
//
// - Load the tenant. If unable to, fail the conclusion check run.
@@ -1072,7 +1072,6 @@ namespace brep
move (br)))
{
assert (cr.state == build_state::built);
-
return cr;
}
else
@@ -1118,7 +1117,9 @@ namespace brep
repository_location rl (move (ru), repository_type::git);
optional<start_result> r (load (error, warn, verb_ ? &trace : nullptr,
- *build_db_, move (ts), move (rl)));
+ *build_db_,
+ move (ts),
+ move (rl)));
if (!r || r->status != 200)
{
@@ -1134,7 +1135,8 @@ namespace brep
// Nothing really we can do in this case since we will not receive
// any further notifications. Log the error as a last resort.
- error << "failed to load CI tenant " << ts.id;
+ error << "failed to load CI tenant " << ts.id
+ << " and unable to update conclusion";
}
return nullptr; // No need to update service data in this case.