aboutsummaryrefslogtreecommitdiff
path: root/mod/mod-ci-github-gq.hxx
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-10-31 15:03:10 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-11-04 11:10:53 +0200
commitb4ea7fc17b0b69ac21cf517120b88f76296d57a7 (patch)
treeb17f317b0d6ccf4bddad36573d106c6dbf414795 /mod/mod-ci-github-gq.hxx
parentf6c3eea2ddb5bd8a643a34f422bef57d676fc702 (diff)
Update comments
Diffstat (limited to 'mod/mod-ci-github-gq.hxx')
-rw-r--r--mod/mod-ci-github-gq.hxx15
1 files changed, 12 insertions, 3 deletions
diff --git a/mod/mod-ci-github-gq.hxx b/mod/mod-ci-github-gq.hxx
index 72283ee..3083696 100644
--- a/mod/mod-ci-github-gq.hxx
+++ b/mod/mod-ci-github-gq.hxx
@@ -26,6 +26,11 @@ namespace brep
// Note: no details_url yet since there will be no entry in the build result
// search page until the task starts building.
//
+ // Note that creating a check_run named `foo` will effectively replace any
+ // existing check_runs with that name. They will still exist on the GitHub
+ // servers but GitHub will only consider the latest one (for display in the
+ // UI or in determining the mergeability of a PR).
+ //
bool
gq_create_check_runs (const basic_mark& error,
vector<check_run>& check_runs,
@@ -86,7 +91,7 @@ namespace brep
// Fetch pre-check information for a pull request from GitHub. This
// information is used to decide whether or not to CI the PR and is
// comprised of the PR's head commit SHA, whether its head branch is behind
- // its base branch, and its test merge commit SHA.
+ // its base branch, and its mergeability and test merge commit SHA.
//
// Return absent value if the merge commit is still being generated (which
// means PR head branch behindness is not yet known either). See the
@@ -97,8 +102,12 @@ namespace brep
// will be treated by the caller as still being generated).
//
// Note that the first request causes GitHub to start preparing the test
- // merge commit. (For details see
- // https://docs.github.com/rest/guides/getting-started-with-the-git-database-api#checking-mergeability-of-pull-requests.)
+ // merge commit.
+ //
+ // For details regarding the test merge commit and how to check/poll for PR
+ // mergeability see
+ // https://docs.github.com/en/rest/pulls/pulls?#get-a-pull-request and
+ // https://docs.github.com/en/rest/guides/using-the-rest-api-to-interact-with-your-git-database?#checking-mergeability-of-pull-requests
//
struct gq_pr_pre_check_info
{