aboutsummaryrefslogtreecommitdiff
path: root/mod/mod-ci-github-gq.cxx
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-05-10 14:15:25 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-10-15 09:05:28 +0200
commitdc3a911495292fc6eda318fac32f5606ffb12568 (patch)
tree4cda19118e7e29230c918fa137beb664b3d288db /mod/mod-ci-github-gq.cxx
parenta515e647cbba6a2bdb2b6fb764b02fa23b7d2652 (diff)
Post-review changes
Diffstat (limited to 'mod/mod-ci-github-gq.cxx')
-rw-r--r--mod/mod-ci-github-gq.cxx9
1 files changed, 2 insertions, 7 deletions
diff --git a/mod/mod-ci-github-gq.cxx b/mod/mod-ci-github-gq.cxx
index bea9a7f..954f5a8 100644
--- a/mod/mod-ci-github-gq.cxx
+++ b/mod/mod-ci-github-gq.cxx
@@ -80,9 +80,7 @@ namespace brep
// serialize data to a stringstream and only parse it later once we're
// sure there are no errors.
//
- ostringstream data; // The value of the data field.
-
- // @@@ Use iostringstream for both output and input.
+ stringstream data; // The value of the data field.
p.next_expect (event::begin_object);
@@ -144,8 +142,7 @@ namespace brep
// Parse the data field now that we know there are no errors.
//
- string d (data.str ());
- json::parser dp (d, p.input_name);
+ json::parser dp (data, p.input_name);
parse_data (dp);
}
@@ -183,8 +180,6 @@ namespace brep
// }
// }
//
- // @@@ TODO Handle response errors properly.
- //
static vector<gh_check_run>
gq_parse_response_check_runs (json::parser& p)
{