diff options
| author | Boris Kolpackov <boris@codesynthesis.com> | 2024-12-17 15:08:22 +0200 |
|---|---|---|
| committer | Boris Kolpackov <boris@codesynthesis.com> | 2024-12-17 15:08:22 +0200 |
| commit | 5d89c20a2b1469cf396bdb226e719f5009c4fcab (patch) | |
| tree | 40519e6755a93eb72c528d941e911070f56f9bfe | |
| parent | 17d5a70735ae954ef6eefdc9190c6164440de312 (diff) | |
Reviewci-github-3
| -rw-r--r-- | mod/mod-ci-github.cxx | 11 | ||||
| -rw-r--r-- | mod/mod-ci-github.hxx | 2 |
2 files changed, 7 insertions, 6 deletions
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index ac98785..8f796af 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -1435,7 +1435,7 @@ namespace brep : ""); // Note that PR rebuilds (re-requested) are handled by - // handle_check_suite_request(). + // handle_check_suite_rerequest(). // // Note that, in the case of a remote PR, GitHub will copy the PR head // commit from the head (forked) repository into the base repository. So @@ -1462,7 +1462,7 @@ namespace brep // Create with an empty service id so that the generated tenant id is used // instead during the pre-check phase (so as not to clash with a proper // service id for this head commit, potentially created in - // handle_check_suite() or as another PR). + // handle_branch_push() or as another PR). // tenant_service ts ("", "ci-github", sd.json ()); @@ -1502,7 +1502,7 @@ namespace brep // if (ps.forced || ps.deleted) { - // The common log entry subject. + // The common log entry subject. @@ Move inline. // string sub (ps.forced ? "forced push " + ps.after + " to " + ps.ref : "deletion of " + ps.ref); @@ -1581,8 +1581,9 @@ namespace brep ps.after /* report_sha */); // Create an unloaded CI tenant, doing nothing if one already exists - // (which could've been created by handle_pull_request()). Note that the - // tenant's reference count is incremented in all cases. + // (which could've been created by handle_pull_request() or by us as as + // result of a push to another branch). Note that the tenant's reference + // count is incremented in all cases. // // Note: use no delay since we need to (re)create the synthetic conclusion // check run as soon as possible. diff --git a/mod/mod-ci-github.hxx b/mod/mod-ci-github.hxx index 3b7d2aa..4f69f5c 100644 --- a/mod/mod-ci-github.hxx +++ b/mod/mod-ci-github.hxx @@ -122,7 +122,7 @@ namespace brep // and to FAILURE otherwise. // bool - handle_push_request (gh_push_event, bool warning_success); + handle_branch_push (gh_push_event, bool warning_success); // Build a check run details_url for a build. // |