aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancois Kritzinger <francois@codesynthesis.com>2024-05-02 14:43:27 +0200
committerFrancois Kritzinger <francois@codesynthesis.com>2024-10-15 09:05:28 +0200
commit912c94d987d3b2bd7500469090873a1575c4dbfb (patch)
treeaecca05e2493db0f0c623fc742edf9fc75f1f12a
parentdb68834454f22ceab0ef0638f0d8beee57218335 (diff)
Post-review changes
-rw-r--r--mod/mod-ci-github-gq.cxx6
-rw-r--r--mod/mod-ci-github.cxx2
2 files changed, 6 insertions, 2 deletions
diff --git a/mod/mod-ci-github-gq.cxx b/mod/mod-ci-github-gq.cxx
index 8e436e9..4a4f56d 100644
--- a/mod/mod-ci-github-gq.cxx
+++ b/mod/mod-ci-github-gq.cxx
@@ -494,10 +494,14 @@ namespace brep
build_state st,
optional<gq_built_result> br)
{
- // Must have a result if state is built. @@ du?
+ // Must have a result if state is built.
//
assert (st != build_state::built || br);
+ // Must have a details URL for building and built.
+ //
+ assert (!du.empty ());
+
string rq (
gq_serialize_request (
gq_mutation_update_check_run (rid,
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx
index 9c084ba..dc21e0e 100644
--- a/mod/mod-ci-github.cxx
+++ b/mod/mod-ci-github.cxx
@@ -869,7 +869,7 @@ namespace brep
iat->token,
sd.repository_id,
*cr.node_id,
- "", // Don't update details_url again. @@
+ details_url (b),
build_state::built,
move (br)))
{