diff options
| author | Francois Kritzinger <francois@codesynthesis.com> | 2024-04-25 10:10:02 +0200 |
|---|---|---|
| committer | Francois Kritzinger <francois@codesynthesis.com> | 2024-04-26 07:24:23 +0200 |
| commit | ddef9fe292621388d0c99bf8e0f2aa9517efe39b (patch) | |
| tree | 8208c67c760384081bc1b6291af567da6e92f771 | |
| parent | 0c93c56054a015d714c1e3332628c43ed088d4c8 (diff) | |
Post-review changes
| -rw-r--r-- | mod/mod-ci-github.cxx | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/mod/mod-ci-github.cxx b/mod/mod-ci-github.cxx index 426dc60..dd9cfc0 100644 --- a/mod/mod-ci-github.cxx +++ b/mod/mod-ci-github.cxx @@ -633,7 +633,7 @@ namespace brep if (scr->node_id) { cr = move (*scr); - cr.state_synced = false; + cr->state_synced = false; } else ; // Network error during queued notification, ignore. @@ -669,7 +669,7 @@ namespace brep iat = &sd.installation_access; // Note: we treat the failure to obtain the installation access token the - // same as the failure to notify GitHub (state is updated by not marked + // same as the failure to notify GitHub (state is updated but not marked // synced). // if (iat != nullptr) @@ -677,16 +677,14 @@ namespace brep if (gq_update_check_run (*cr, iat->token, sd.repository_id, - *cr.node_id, + *cr->node_id, build_state::building, error)) { // Do nothing further if the state was already built on GitHub (note - // that this is based on the above-mentioned special GitHub semanitcs + // that this is based on the above-mentioned special GitHub semantics // of preventing changes to the built status). // - // @@ Can we confirm this? - // if (cr->state == build_state::built) { warn << "check run " << bid << ": already in built state on GitHub"; @@ -694,14 +692,14 @@ namespace brep return nullptr; } - assert (cr.state == build_state::building); + assert (cr->state == build_state::building); - l3 ([&]{trace << "updated check_run { " << cr << " }";}); + l3 ([&]{trace << "updated check_run { " << *cr << " }";}); } } return [iat = move (new_iat), - cr = move (cr), + cr = move (*cr), error = move (error), warn = move (warn)] (const tenant_service& ts) -> optional<string> { |