aboutsummaryrefslogtreecommitdiff
path: root/bpkg/pkg-build.cxx
diff options
context:
space:
mode:
Diffstat (limited to 'bpkg/pkg-build.cxx')
-rw-r--r--bpkg/pkg-build.cxx11
1 files changed, 7 insertions, 4 deletions
diff --git a/bpkg/pkg-build.cxx b/bpkg/pkg-build.cxx
index 0ebe992..fac79c2 100644
--- a/bpkg/pkg-build.cxx
+++ b/bpkg/pkg-build.cxx
@@ -4861,7 +4861,9 @@ namespace bpkg
sp = pdb->find<selected_package> (pa.name);
// Make sure that the package is known. Only allow to unhold an
- // unknown orphaned selected package.
+ // unknown orphaned selected package (with the view that there is
+ // a good chance it will get dropped; and if not, such an unhold
+ // should be harmless).
//
if (!existing &&
find_available (repo_configs,
@@ -4869,9 +4871,10 @@ namespace bpkg
!sys ? pa.constraint : nullopt).empty ())
{
// Don't fail if the selected package is held and satisfies the
- // constraints, if specified. Note that we may still fail later if
- // the dependency is requested to be deorphaned and still have the
- // dependents.
+ // constraints, if specified. Note that we may still fail later
+ // with the "not available from its dependents' repositories"
+ // error if the dependency is requested to be deorphaned and all
+ // its dependents are orphaned.
//
if (!(sp != nullptr &&
sp->hold_package &&